You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2016/11/13 19:19:15 UTC
[GitHub] zeppelin pull request #1627: [ZEPPELIN-1658] Big download button and display...
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/1627
[ZEPPELIN-1658] Big download button and display package size
### What is this PR for?
Make big download button for bin package to make choices easy.
### What type of PR is it?
Improvement
### Todos
* [x] - Big button and display package size
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1658
### How should this be tested?
Run gh-pages branch locally
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin gh-pages_large-download-button
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1627.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1627
----
commit a7841d0be2084bea231bc8e6fb09d130a4d9415b
Author: Lee moon soo <mo...@apache.org>
Date: 2016-11-13T19:12:55Z
Big download button and display package size
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1627: [ZEPPELIN-1658] Big download button and display packag...
Posted by tae-jun <gi...@git.apache.org>.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1627
LGTM! \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1627: [ZEPPELIN-1658] Big download button and display...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1627
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1627: [ZEPPELIN-1658] Big download button and display packag...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1627
Thanks @tae-jun for review.
Merge to gh-pages if there're no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---