You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/15 16:46:51 UTC

[GitHub] [arrow-ballista] alamb commented on a diff in pull request #124: Ballista Executor report plan/operators metrics to Ballista Scheduler

alamb commented on code in PR #124:
URL: https://github.com/apache/arrow-ballista/pull/124#discussion_r945939365


##########
ballista/rust/core/proto/ballista.proto:
##########
@@ -503,6 +504,41 @@ message ColumnStats {
   uint32 distinct_count = 4;
 }
 
+message OperatorMetricsSet {
+  repeated OperatorMetric metrics = 1;
+}
+
+
+message NamedCount {
+  string name = 1;
+  uint64 value = 2;
+}
+
+message NamedGauge {
+  string name = 1;
+  uint64 value = 2;

Review Comment:
   I think changing `Gauge` in datafusion to use `AtomicI64` rather than `AtomicUsize` would make sense to me 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org