You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/17 10:44:00 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8163: fs: Define DT_xxx to number directly
xiaoxiang781216 opened a new pull request, #8163:
URL: https://github.com/apache/nuttx/pull/8163
## Summary
and map DTYPE_xxx to DT_xxx like other OS
## Impact
no real change
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396556478
what's the point of this change? are you going to remove DTYPE_xxx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398482685
Sorry, I don't see there is anything reason to revert this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396608420
> > > Since iattr and ATTR_xxx isn't defined in nuttx.
> >
> >
> > it's something you should provide as a part of nuttx glue logic, isn't it?
>
> Sorry, I don't think so. If NuttX can make the change to more compatible with 3rd party library and without any side effect like this patch. Why not do it?
>
> > anyway, if yaffs2 is broken, i'd suggest to fix it instead.
>
> But it can compile without any warning with Linux which define these macros too since the compiler allow the same macro define multiple times if the late definition is same as earlier one.
for the most of macros in the file is defined as the following. i don't understand why these need to be different.
```
#ifndef XATTR_REPLACE
#define XATTR_REPLACE 2
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396584516
> Since iattr and ATTR_xxx isn't defined in nuttx.
it's something you should provide as a part of nuttx glue logic, isn't it?
anyway, if yaffs2 is broken, i'd suggest to fix it instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1398110929
@xiaoxiang781216 @yamt so what is the path to move forward here? I read that this change brings regression to `yaffs2` and the natural step seems to be reverting of a change and re-evaluating it to a new solution that covers broken cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396600615
> > Since iattr and ATTR_xxx isn't defined in nuttx.
>
> it's something you should provide as a part of nuttx glue logic, isn't it?
>
Sorry, I don't think so. If NuttX can make the change to more compatible with 3rd party library and without any side effect. Why not do it?
> anyway, if yaffs2 is broken, i'd suggest to fix it instead.
But it can compile without any warning with Linux which define these macros too since the compiler allow the same macro define multiple times if the late definition is same as earlier one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396575435
Since iattr and ATTR_xxx isn't defined in nuttx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396559754
> what's the point of this change?
There is code which redefines DT_xxxx(e.g., http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0dee9a0b533363c1511e1;hb=HEAD#l52). This change avoids the compiler generate the macro redefinition warning.
> are you going to remove DTYPE_xxx?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #8163:
URL: https://github.com/apache/nuttx/pull/8163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] yamt commented on pull request #8163: fs: Define DT_xxx to number directly
Posted by GitBox <gi...@apache.org>.
yamt commented on PR #8163:
URL: https://github.com/apache/nuttx/pull/8163#issuecomment-1396572081
> > what's the point of this change?
>
> There is code which redefines DT_xxxx(e.g., http://www.aleph1.co.uk/gitweb/?p=yaffs2.git;a=blob;f=direct/yportenv.h;h=5a79f93583b963d715b0dee9a0b533363c1511e1;hb=HEAD#l52). This change avoids the compiler generate the macro redefinition warning.
why don't you disable CONFIG_YAFFS_PROVIDE_DEFS and use definitions for nuttx?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org