You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/12 05:14:47 UTC

[GitHub] [beam] boyuanzz commented on a change in pull request #11911: [BEAM-10186] Send an error to the runner for certain split and progress failures

boyuanzz commented on a change in pull request #11911:
URL: https://github.com/apache/beam/pull/11911#discussion_r439210538



##########
File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/control/BeamFnControlClient.java
##########
@@ -159,6 +159,16 @@ public void processInstructionRequests(Executor executor)
             } catch (Error e) {
               sendErrorResponse(e);
               throw e;
+            } catch (IllegalStateException e) {

Review comment:
       Do we only care about `IllegalStateException ` here? It seems like other exceptions might also be thrown.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org