You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/06 00:59:27 UTC

[GitHub] [arrow-datafusion] comphead commented on a diff in pull request #2840: Preserve list element name

comphead commented on code in PR #2840:
URL: https://github.com/apache/arrow-datafusion/pull/2840#discussion_r914314260


##########
datafusion/proto/src/from_proto.rs:
##########
@@ -656,21 +658,22 @@ impl TryFrom<&protobuf::ScalarListValue> for ScalarValue {
     fn try_from(
         scalar_list_value: &protobuf::ScalarListValue,
     ) -> Result<Self, Self::Error> {
-        use protobuf::{scalar_type::Datatype, PrimitiveScalarType};
+        if 2 > 1 {

Review Comment:
   @tustvold im not sure why all tests are ok, looks like this piece of code not used. The CI build also has Ballista tests?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org