[GitHub] [accumulo] PircDef commented on a change in pull request #1968: Enhance Crypto

[GitBox <gi...@apache.org>]

PircDef commented on a change in pull request #1968:
URL: https://github.com/apache/accumulo/pull/1968#discussion_r597694874



##########
File path: core/src/main/java/org/apache/accumulo/core/crypto/CryptoServiceFactory.java
##########
@@ -56,11 +96,50 @@ public static CryptoService newInstance(AccumuloConfiguration conf, ClassloaderT
       throw new IllegalArgumentException();
     }
 
-    newCryptoService.init(conf.getAllPropertiesWithPrefix(Property.INSTANCE_CRYPTO_PREFIX));
-    return newCryptoService;
+    var encrypter = newCryptoService.getEncrypter();
+    encrypter.init(initParams);
+    return encrypter;
   }
 
-  public static CryptoService newDefaultInstance() {
-    return newInstance(DefaultConfiguration.getInstance(), ClassloaderType.JAVA);
+  public static List<CryptoService> getDecrypters(AccumuloConfiguration conf, ClassloaderType ct) {
+    String[] classes = conf.get(TABLE_CRYPTO_DECRYPT_SERVICES).split(",");

Review comment:
       Should this also load the TABLE_CRYPTO_ENCRYPT_SERVICE decrypter under the expectation that the service currently configured to encrypt will also be needed to decrypt? If not, should we add a note to the Property.java making it clear that the service much be set in both locations?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org