You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/07/19 07:45:47 UTC

[GitHub] [incubator-inlong] charlely commented on a change in pull request #557: [INLONG-755]Go SDK Consumer Result

charlely commented on a change in pull request #557:
URL: https://github.com/apache/incubator-inlong/pull/557#discussion_r672061392



##########
File path: tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -383,7 +383,7 @@ func (c *consumer) processRebalanceEvent() {
 }
 
 func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) {
-	log.Tracef("[disconnect2Broker] connect event begin, client id=%s", c.clientID)
+	log.Tracef("[disconnect2Broker] connect event begin, client=%s", c.clientID)

Review comment:
       This is disconnect function, but this is concet event.

##########
File path: tubemq-client-twins/tubemq-client-go/client/consumer_impl.go
##########
@@ -393,7 +393,7 @@ func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) {
 		}
 	}
 	event.SetEventStatus(metadata.Disconnect)
-	log.Tracef("[disconnect2Broker] connect event finished, client id=%s", c.clientID)
+	log.Tracef("[disconnect2Broker] connect event finished, client=%s", c.clientID)

Review comment:
       dito




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org