[GitHub] [incubator-yunikorn-core] kingamarton commented on pull request #198: [WIP][YUNIKORN-366] Add rest API to update queue configuration

[GitBox <gi...@apache.org>]

kingamarton commented on pull request #198:
URL: https://github.com/apache/incubator-yunikorn-core/pull/198#issuecomment-680954715


   > hi @kingamarton
   > 
   > Thanks for the PR. Except for the changes in this PR, could you please check the logic here:
   > 
   > https://github.com/apache/incubator-yunikorn-core/blob/742e21611d15da8e3c8d5441f8d3b42d8532634c/pkg/common/configs/configwatcher.go#L93-L97
   > 
   > , see if this is enough to prevent a dup refresh?
   
   @yangwwei, I already checked that part and I am afraid that a dup refresh is not possible(or it not straightforward how to do it) to prevent in every case because the config reloader is triggered at the moment when the configmap is changed. However I will have to find out a solution for this issue, because I debugged the actual workflow and I can see that after the configuration is refreshed in the scheduler, the configwatcher will revert the changes, because it is triggered, but since there is a delay in observing the changes in the pod, it detects the difference between the pod(still having the old config) and the scheduler (having already the new config), and will change the configuration in the scheduler.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org