You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hannah Nguyen (Code Review)" <ge...@cloudera.org> on 2020/03/01 01:01:33 UTC
[kudu-CR] KUDU-2780: create thread for auto-rebalancing
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 )
Change subject: KUDU-2780: create thread for auto-rebalancing
......................................................................
Patch Set 17:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc
File src/kudu/master/auto_rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/master/auto_rebalancer.cc@261
PS17, Line 261: continue;
> If we're moving on without successfully executing and calling CheckReplicaM
Changed GetMoves() and added comments to note that 'replica_moves' and 'has_location_violations' will not be updated if GetMoves() fails. The loop should continue and pass the DCHECK next iteration.
'replica_moves' is passed by const ref in ExecuteMoves(), and returns in failure if a move cannot be scheduled.
Changing this to WARN_NOT_OK() and proceeding with calling CheckReplicaMovesCompleted() after, which should catch the failure to schedule and remove the move from 'replica_moves'.
Also going to add a test with unstable Raft configurations to verify the DCHECK passes, thank you. :)
http://gerrit.cloudera.org:8080/#/c/14177/14/src/kudu/rebalance/rebalancer.cc
File src/kudu/rebalance/rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/14177/14/src/kudu/rebalance/rebalancer.cc@489
PS14, Line 489: std::mt19937 random_generato
> Should this be passed as a pointer since it's an in-out param? Otherwise, i
Done
http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/rebalance/rebalancer.cc
File src/kudu/rebalance/rebalancer.cc:
http://gerrit.cloudera.org:8080/#/c/14177/17/src/kudu/rebalance/rebalancer.cc@489
PS17, Line 489: std::mt19937 random_generator,
: vector<string> tablet_ids,
> It seems Andrew's comment about copying/passing by values hasn't been addre
Done. Thanks for catching this--I missed it!
--
To view, visit http://gerrit.cloudera.org:8080/14177
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifca25d1063c07047cf2123e6792b3c7395be20e4
Gerrit-Change-Number: 14177
Gerrit-PatchSet: 17
Gerrit-Owner: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hannah Nguyen <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Sun, 01 Mar 2020 01:01:33 +0000
Gerrit-HasComments: Yes