You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/04/14 13:54:24 UTC

[GitHub] [arrow-rs] mustafasrepo opened a new pull request, #4089: [Minor]: Add hash trait to SortOptions.

mustafasrepo opened a new pull request, #4089:
URL: https://github.com/apache/arrow-rs/pull/4089

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
    `SortOptions` doesn't implement `Hash` trait. This prevents us to use `HashSet`, `HashMap` with this type. (Or structs having field of this type).
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   This Pr adds `Hash` trait for `SortOptions` type.
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on pull request #4089: [Minor]: Add hash trait to SortOptions.

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #4089:
URL: https://github.com/apache/arrow-rs/pull/4089#issuecomment-1509220036

   Thanks @mustafasrepo 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb merged pull request #4089: [Minor]: Add `Hash` trait to SortOptions.

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #4089:
URL: https://github.com/apache/arrow-rs/pull/4089


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org