Fwd: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI labels (#17)

[Pierre Smits <pi...@apache.org>]

Jacques,

Be happy with what you got! I would not want to burden you (or others) with
patches too large to check.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer


---------- Forwarded message ---------
From: Jacques Le Roux <no...@github.com>
Date: Thu, Feb 27, 2020 at 10:14 AM
Subject: Re: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI labels
(#17)
To: apache/ofbiz-framework <of...@noreply.github.com>
Cc: Pierre Smits <pi...@apache.org>, Author <author@noreply.github.com
>


Hi Pierre,

I checked on trunk demo with the label manager for AccountingUiLabels.xml
and then by hand locally. At least the 5 1st ones reported by the label
manager are unused. Could you please check on your side and complete the
patch?
TIA

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/apache/ofbiz-framework/pull/17?email_source=notifications&email_token=AA6ERMWCW7GFVIUBSKKAQYTRE577LA5CNFSM4KZAQFF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDSDBI#issuecomment-591864197>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA6ERMQOVICQFWKH3XICAS3RE577LANCNFSM4KZAQFFQ>
.

Re: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI labels (#17)

[Pierre Smits <pi...@apache.org>]

Jacques, all,

I am confident there are way more labels unused across the total of
components in both the base and the plugins repository than the number you
mentioned. And typos, and pieces of code not used.

That should not lead to *not* merging cleanups as they are presented. Some
of your peers have expressed in the past that this is a kind of menial
work. Others have expressed that these kind of issues are of trivial
importance. Maybe they (still) feel themselves to good to collaborate on
these kind of issues.

The project sends a wrong signal, when privileged contributors don't react
positively and timely to this kind of low hanging fruit. Not only to
developers considering their first steps in contributing. But also to
potential adopters (and their advisors) regarding cleanliness of the
product, and the liveliness of and how welcoming the project is, when
reading through the mailing lists and going through tickets.

Met vriendelijke groet,

Pierre Smits
*Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
2008 (without privileges)

*Apache Trafodion <https://trafodion.apache.org/>, Vice President*
*Apache Directory <https://directory.apache.org/>, PMC Member*
Apache Incubator <https://incubator.apache.org/>, committer
Apache Steve <https://steve.apache.org/>, committer



Op do 27 feb. 2020 10:42 schreef Pierre Smits <pi...@apache.org>:

> Jacques,
>
> Be happy with what you got! I would not want to burden you (or others)
> with patches too large to check.
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor** of* Apache OFBiz <https://ofbiz.apache.org/> since
> 2008 (without privileges)
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> Apache Steve <https://steve.apache.org>, committer
>
>
> ---------- Forwarded message ---------
> From: Jacques Le Roux <no...@github.com>
> Date: Thu, Feb 27, 2020 at 10:14 AM
> Subject: Re: [apache/ofbiz-framework] OFBIZ-10565 Removing unused UI
> labels (#17)
> To: apache/ofbiz-framework <of...@noreply.github.com>
> Cc: Pierre Smits <pi...@apache.org>, Author <
> author@noreply.github.com>
>
>
> Hi Pierre,
>
> I checked on trunk demo with the label manager for AccountingUiLabels.xml
> and then by hand locally. At least the 5 1st ones reported by the label
> manager are unused. Could you please check on your side and complete the
> patch?
> TIA
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/ofbiz-framework/pull/17?email_source=notifications&email_token=AA6ERMWCW7GFVIUBSKKAQYTRE577LA5CNFSM4KZAQFF2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENDSDBI#issuecomment-591864197>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AA6ERMQOVICQFWKH3XICAS3RE577LANCNFSM4KZAQFFQ>
> .
>