[jira] [Commented] (DRILL-5326) Unit tests failures related to the SERVER_METADTA

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-5326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900155#comment-15900155 ] 

ASF GitHub Bot commented on DRILL-5326:
---------------------------------------

GitHub user vdiravka opened a pull request:

    https://github.com/apache/drill/pull/775

    DRILL-5326: Unit tests failures related to the SERVER_METADTA

    - adding of the sql type name for the "GENERIC_OBJECT";
    - changing "NullCollation" in the "ServerMetaProvider" to the correct default value;

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vdiravka/drill DRILL-5326

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/775.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #775
    
----
commit e7ca7650fa1bcc32638cfe4aade96aa56406a362
Author: Vitalii Diravka <vi...@gmail.com>
Date:   2017-03-07T20:53:03Z

    DRILL-5326: Unit tests failures related to the SERVER_METADTA
    - adding of the sql type name for the "GENERIC_OBJECT";
    - changing "NullCollation" in the "ServerMetaProvider" to the correct default value;

----


> Unit tests failures related to the SERVER_METADTA
> -------------------------------------------------
>
>                 Key: DRILL-5326
>                 URL: https://issues.apache.org/jira/browse/DRILL-5326
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Metadata
>    Affects Versions: 1.10.0
>            Reporter: Vitalii Diravka
>            Assignee: Vitalii Diravka
>            Priority: Blocker
>             Fix For: 1.10.0
>
>
> 1. In DRILL-5301 a new SERVER_META rpc call was introduced. The server will support this method only from 1.10.0 drill version. For drill 1.10.0-SNAPHOT it is disabled. 
> When I enabled this method (by way of upgrading drill version to 1.10.0 or 1.11.0-SNAPSHOT) I found the following exception:
> {code}
> java.lang.AssertionError: Unexpected/unhandled MinorType value GENERIC_OBJECT
> {code}
> It appears in several tests (for example in DatabaseMetadataTest#testNullsAreSortedMethodsSaySortedHigh).
> The reason of it is "GENERIC_OBJECT" RPC-/protobuf-level type is appeared in the ServerMetadata#ConvertSupportList. (Supporting of GENERIC_OBJECT was added in DRILL-1126).
> The proposed solution is to add the appropriate "JAVA_OBJECT" sql type name for this "GENERIC_OBJECT" RPC-/protobuf-level data type.
> 2. After the fixing first one the mentioned above test still fails by reason of the incorrect "NullCollation" value in the "ServerMetaProvider". According to the [doc|https://drill.apache.org/docs/order-by-clause/#usage-notes] the default val should be NC_HIGH (NULL is the highest value).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)