You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/10/24 22:24:35 UTC

Re: Review Request 14910: Fixed slave to properly recover latest run of completed executors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14910/
-----------------------------------------------------------

(Updated Oct. 24, 2013, 8:24 p.m.)


Review request for mesos, Benjamin Hindman and Ben Mahler.


Changes
-------

benm's. NNFR.


Summary (updated)
-----------------

Fixed slave to properly recover latest run of completed executors.


Bugs: MESOS-737
    https://issues.apache.org/jira/browse/MESOS-737


Repository: mesos-git


Description
-------

Now the slave recovers completed executors instead of skipping them. This allows the webui to show them even after a restart.

Also simplified the semantics of removeExecutor(). It no longer implicitly does removeFramework().


Diffs (updated)
-----

  src/slave/slave.cpp debb2f4ce05fbfec450197e68bc8a0c78f1d0adf 

Diff: https://reviews.apache.org/r/14910/diff/


Testing
-------

make check

GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="*RecoverCompletedExecutor*" --verbose


Thanks,

Vinod Kone