You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/22 20:06:04 UTC

[GitHub] [airflow] tirkarthi commented on pull request #23177: When marking future tasks, ensure we don't touch other mapped TIs

tirkarthi commented on PR #23177:
URL: https://github.com/apache/airflow/pull/23177#issuecomment-1106821092

   @ashb Please also see https://github.com/apache/airflow/pull/23079 with test cases . This seems to be an issue with the recent logic where trying to clear failed downstream tasks for rerun on marking a task as failure introduced in https://github.com/apache/airflow/pull/13037
   
   Current condition in my PR
   
   ```
   if state == TaskInstanceState.FAILED and (downstream or not altered):
       return altered # Don't clear failed tasks
   ```
   
   Proposed change that will also fix this issue :
   
   ```
   if (state == TaskInstanceState.FAILED and (downstream or not altered)) or mapped_indexes:
       return altered # Don't clear failed tasks
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org