You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/25 11:59:01 UTC
[GitHub] [arrow-datafusion] mingmwang opened a new pull request, #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
mingmwang opened a new pull request, #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4362.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
The PR also added some join UTs to cover different join types. It discloses several bugs and need to be addressed further.
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#discussion_r1032785466
##########
datafusion/sql/src/planner.rs:
##########
@@ -767,7 +767,8 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let join_filter = filter.into_iter().reduce(Expr::and);
if left_keys.is_empty() {
- // When we don't have join keys, use cross join
+ // TODO should not use cross join when the join_filter exists
+ // https://github.com/apache/arrow-datafusion/issues/4363
Review Comment:
Perhaps our current crossjoin implementation is a little strange.
Some databases implement Crossjoin via Nest Loop Join. (cross join is logical, NLJ is physical)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
alamb merged PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#discussion_r1032785613
##########
datafusion/sql/src/planner.rs:
##########
@@ -767,7 +767,8 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
let join_filter = filter.into_iter().reduce(Expr::and);
if left_keys.is_empty() {
- // When we don't have join keys, use cross join
+ // TODO should not use cross join when the join_filter exists
+ // https://github.com/apache/arrow-datafusion/issues/4363
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] mingmwang commented on pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
mingmwang commented on PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#issuecomment-1327393849
@alamb @liukun4515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] liukun4515 commented on a diff in pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
liukun4515 commented on code in PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#discussion_r1032505773
##########
datafusion/core/src/physical_plan/joins/hash_join.rs:
##########
@@ -1554,7 +1554,8 @@ impl HashJoinStream {
}
Some(result.map(|x| x.0))
}
- other => {
+ Some(err) => Some(err),
Review Comment:
👍 this is also found in the refactor pr https://github.com/apache/arrow-datafusion/pull/4377/files#
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #4373: HashJoin should return Err when the right side input stream produce Err, add more join UTs to cover different join types
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #4373:
URL: https://github.com/apache/arrow-datafusion/pull/4373#issuecomment-1328044350
Benchmark runs are scheduled for baseline = 3b7f76714c72a0488f141d2869ada737e0a0df39 and contender = 27ae14aeec840f404d5ebe44e341f5dbea4c6f63. 27ae14aeec840f404d5ebe44e341f5dbea4c6f63 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/7f136823681a4b46af469617254be2c8...92777eb1ddc145c2a73e82eb0eafe2ff/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ec315363d53141238985bb9162a84d67...3f57e2106f6a487d8ab52942402cfac0/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/26b34d84290e40bfbcd7e888b74f7b4b...22f438e4c7864458b9d17a50642dcd39/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/0e4d38f72a8f448fbc41ab9ca4bafcec...9039b77524a64c47a4bdaa6df42549ea/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org