You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by " Kaige Liu (JIRA)" <ji...@apache.org> on 2018/01/27 05:39:00 UTC
[jira] [Commented] (KYLIN-3204) Unclosed resources in
JdbcExplorer#evalQueryMetadata
[ https://issues.apache.org/jira/browse/KYLIN-3204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16341979#comment-16341979 ]
Kaige Liu commented on KYLIN-3204:
-----------------------------------
Hi [~yuzhihong@gmail.com], I think con and rs will be close properly.
{quote}DatabaseMetaData dbmd = con.getMetaData();
ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
ColumnDesc[] result = extractColumnFromMeta(rs);
*DBUtils.closeQuietly(rs);*
*DBUtils.closeQuietly(con);*
{quote}
> Unclosed resources in JdbcExplorer#evalQueryMetadata
> ----------------------------------------------------
>
> Key: KYLIN-3204
> URL: https://issues.apache.org/jira/browse/KYLIN-3204
> Project: Kylin
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Major
>
> {code}
> Connection con = SqlUtil.getConnection(dbconf);
> DatabaseMetaData dbmd = con.getMetaData();
> ResultSet rs = dbmd.getColumns(null, tmpDatabase, tmpView, null);
> {code}
> con and rs should be closed upon return.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)