You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Carsten Ziegeler (JIRA)" <ji...@apache.org> on 2016/12/14 09:08:58 UTC

[jira] [Commented] (FELIX-5404) Annotation configurations default values are not considered

    [ https://issues.apache.org/jira/browse/FELIX-5404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15747753#comment-15747753 ] 

Carsten Ziegeler commented on FELIX-5404:
-----------------------------------------

[~jsedding] Can you provide a full test case? I think the SCR implementation is fine. While you're right that this case is not handled in the Annotations class, this is handled at build time and property elements are generated in the component XML for the default values. 

> Annotation configurations default values are not considered
> -----------------------------------------------------------
>
>                 Key: FELIX-5404
>                 URL: https://issues.apache.org/jira/browse/FELIX-5404
>             Project: Felix
>          Issue Type: Bug
>          Components: Declarative Services (SCR)
>    Affects Versions: scr-2.0.6
>            Reporter: Julian Sedding
>            Assignee: Carsten Ziegeler
>            Priority: Minor
>             Fix For: scr-2.1.0
>
>         Attachments: FELIX-5404-jsedding.patch
>
>
> When an annotation is used to configure an SCR component (as per DS 1.3), the annotation's default values are not considered.
> This can lead to the odd situation that an annotation method with a default value returns null. I'm not sure if this violates a contract or another, however, my IDE complains when I do a null check.
> I think it would be the right thing to do to return the default value if no value is explicitly configured.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)