[GitHub] [solr] janhoy commented on a change in pull request #773: Fix official dockerfile sources and add build steps to RC message

[GitBox <gi...@apache.org>]

janhoy commented on a change in pull request #773:
URL: https://github.com/apache/solr/pull/773#discussion_r837908156



##########
File path: solr/docker/templates/Dockerfile.official.header.template
##########
@@ -34,13 +34,13 @@ ARG SOLR_DOWNLOAD_URL
 # TODO: see patch in SOLR-15250 for some example ideas on fixing this to be more strict
 
 # Override the default solr download location with a prefered mirror, e.g.:
-#   docker build -t mine --build-arg SOLR_DOWNLOAD_SERVER=http://www-eu.apache.org/dist/lucene/solr .
+#   docker build -t mine --build-arg SOLR_DOWNLOAD_SERVER=http://www-eu.apache.org/dist/solr/solr .

Review comment:
       www-eu redirects to downloads:
   ```suggestion
   #   docker build -t mine --build-arg SOLR_DOWNLOAD_SERVER=https://downloads.apache.org/solr/solr .
   ```
   
   Have not thought closely about internal structure, but since we have solr-operator, it may make sense to add the extra `solr` level i.e.  `.../solr/solr/x.y.z/`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org