You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by ChengXiangLi <gi...@git.apache.org> on 2015/09/23 12:25:36 UTC
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
GitHub user ChengXiangLi opened a pull request:
https://github.com/apache/flink/pull/1170
[FLINK-2743] Add XORShfitRandom and use it in RandomSamplers.
Implement the XORShfitRandom based on the XORShift algorithm, it shows 4.5X faster than `java.util.Random` in benchmark. And update all RandomSample implements to use XORShiftRandom.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChengXiangLi/flink xorshiftrandom
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1170.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1170
----
commit 6425b746aac7bab2a2102d7ea623155b83e12965
Author: chengxiang li <ch...@intel.com>
Date: 2015-09-23T10:08:06Z
[FLINK-2743] Add XORShfitRandom and use it in RandomSamplers.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by ChengXiangLi <gi...@git.apache.org>.
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-145249544
Yes, it should be, @StephanEwen , I'm on National Day vocation now, i would update it when i come back to work at Oct 08.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-149341495
Hi @ChengXiangLi, thanks for the update!
Good to merge IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1170
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1170#discussion_r42248517
--- Diff: flink-core/pom.xml ---
@@ -70,6 +74,18 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
--- End diff --
We don't need the JMH dependencies in flink-core anymore, because the benchmarks have been move to the flink-benchmark module, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-149838604
Will merge this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by ChengXiangLi <gi...@git.apache.org>.
Github user ChengXiangLi commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-142780685
Yes, that make sense, i've created the [new benchmark module PR|https://github.com/apache/flink/pull/1177], and i would update this PR after 1177 got merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-145485804
No problem, enjoy!
This is not a blocker for anything right now, so no pressure...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-144784204
I think this can now be rebased to put the microbenchmark into the dedicated maven project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-142657503
Looks good.
You also proposed to add a dedicated project for the microbenchmarks. Should that be created first, so the XORShift benchmark can go in there as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2743] Add XORShfitRandom and use it in ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1170#issuecomment-148736980
Looks good except for the dependencies added to `flink-core/pom.xml`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---