You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/04/20 16:18:05 UTC

[GitHub] [airflow] ashb commented on a change in pull request #8476: Remove duplicate error message on chart connection failure

ashb commented on a change in pull request #8476:
URL: https://github.com/apache/airflow/pull/8476#discussion_r411510894



##########
File path: airflow/www/templates/airflow/nvd3.html
##########
@@ -160,9 +160,6 @@ <h4 class="panel-title">
       url = "{{ url_for('airflow.chart_data') }}" + location.search;
       $.getJSON(url, function(payload) {
         $('#loading').hide();
-        if (payload.error !== undefined) {
-          $('#chart_body').html('<div class="alert alert-danger">' + payload.error + '</div>');

Review comment:
       The error is still shown by the error function on L181




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org