You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/06/12 17:03:03 UTC
[GitHub] [camel] jam01 opened a new pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
jam01 opened a new pull request #3908:
URL: https://github.com/apache/camel/pull/3908
This enables the plugins to identify rest component through
org.apache.camel.springboot:camel-{component}-starter dependencies.
Instead of needing
```
<dependency>
<groupId>org.apache.camel.springboot</groupId>
<artifactId>camel-netty-http-starter</artifactId>
</dependency>
<dependency>
<groupId>org.apache.camel</groupId>
<artifactId>camel-netty-http</artifactId>
</dependency>
```
for the generator to pick up netty-http, we can just do
```
<dependency>
<groupId>org.apache.camel.springboot</groupId>
<artifactId>camel-netty-http-starter</artifactId>
</dependency>
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #3908:
URL: https://github.com/apache/camel/pull/3908#issuecomment-643514055
No worries, camel is a huge project. I should've been more descriptive...
In this last commit I'm pulling duplicated logic from Generate and GenerateXml into AbstractGenerate and making the groupId fix there. The same treatment for both swagger and openapi plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #3908:
URL: https://github.com/apache/camel/pull/3908#issuecomment-643386411
If you do need me to create a Jira ticket for this let me know.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #3908:
URL: https://github.com/apache/camel/pull/3908#issuecomment-643423608
Oh actually, if the app is Spring boot and the generator defaults to `camel-servlet-starter` it'd use the wrong groupId `org.apache.camel`
https://github.com/apache/camel/blob/master/tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/GenerateMojo.java#L110
which I think has been deprecated? So probably left over code before migrating starters to `org.apache.camel.springboot`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
davsclaus merged pull request #3908:
URL: https://github.com/apache/camel/pull/3908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] jam01 commented on pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
jam01 commented on pull request #3908:
URL: https://github.com/apache/camel/pull/3908#issuecomment-643418743
Oh... Maybe I misunderstood something.
The code already has Spring Boot specific logic:
https://github.com/apache/camel/blob/master/tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/AbstractGenerateMojo.java#L247
https://github.com/apache/camel/blob/master/tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/GenerateMojo.java#L153
It adds spring boot camel-servlet-starter when other camel-{component} is not found. So it felt appropriate to find existing camel-{component}-starter if they were declared
https://github.com/apache/camel/blob/master/tooling/maven/camel-restdsl-openapi-plugin/src/main/java/org/apache/camel/maven/generator/openapi/GenerateMojo.java#L106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
davsclaus commented on pull request #3908:
URL: https://github.com/apache/camel/pull/3908#issuecomment-643427051
Ah sorry yeah if you can update the group id for spring boot so it would work for all runtimes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus closed pull request #3908: restdsl-openapi/swagger-plugin: support for component-starter dep
Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #3908:
URL: https://github.com/apache/camel/pull/3908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org