You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Andreas Stieger <an...@gmx.de> on 2013/11/23 21:41:53 UTC
[PATCH] Ensure full distribution description is printed in svn --version
-v
Hello,
found a string handling issue:
$ svn --version -v
[...]
- openSUSE 12 (Mantis) [Linux 3.4.63-2.44-desktop]
[...] ^^^
This when "lsb_release -a" clearly contains:
Description: openSUSE 12.2 (i586)
Turns out stringbuf_split_key calculates the buffer length incorrectly,
causing the distribution name to be cut off after the length of the
label instead of the remaining string, in this case 11 characters. Patch
attached.
[[[
Ensure full distribution description is printed in svn --version -v
* subversion/libsvn_subr/sysinfo.c
(stringbuf_split_key): fix buffer length calculation
]]]
With kind regards,
Andreas Stieger
Re: [PATCH] Ensure full distribution description is printed in svn
--version -v
Posted by Ben Reser <be...@reser.org>.
On 11/23/13 12:41 PM, Andreas Stieger wrote:
> found a string handling issue:
> $ svn --version -v
> [...]
> - openSUSE 12 (Mantis) [Linux 3.4.63-2.44-desktop]
> [...] ^^^
> This when "lsb_release -a" clearly contains:
> Description: openSUSE 12.2 (i586)
>
> Turns out stringbuf_split_key calculates the buffer length incorrectly,
> causing the distribution name to be cut off after the length of the
> label instead of the remaining string, in this case 11 characters. Patch
> attached.
>
> [[[
> Ensure full distribution description is printed in svn --version -v
>
> * subversion/libsvn_subr/sysinfo.c
> (stringbuf_split_key): fix buffer length calculation
> ]]]
Committed in r1544878 with my approval.