You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/13 20:13:27 UTC
[GitHub] villebro opened a new pull request #5392: Fix display limit in sql
lab
villebro opened a new pull request #5392: Fix display limit in sql lab
URL: https://github.com/apache/incubator-superset/pull/5392
Limits query by `DISPLAY_SQL_MAX_ROW` (default value 1,000) instead of `SQL_MAX_ROW` (default value 1,000,000). Fixes #5390. This could also be fixed by changing the default values of `SQL_MAX_ROW` to something more manageable, say 1,000. Raises the question of the need for having a separate `SQL_MAX_ROW` as opposed to `DISPLAY_SQL_MAX_ROW` in `config.py`, as there doesn't seem to be any other reference to `SQL_MAX_ROW` in the code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org