[jira] Commented: (GERONIMO-106) Deployment Planner base-class

[ji...@codehaus.org]

The following comment has been added to this issue:

     Author: Aaron Mulder
    Created: Wed, 22 Oct 2003 9:34 AM
       Body:
I don't agree with the patch as it stands, for a number of reasons.  However, there is good code here, and I think I can rearrange it into a more agreeable form.

 - Don't like the packaging (both actual names and decisions on which classes go where)

 - Don't think DDLoader merits 3 classes, particularly when the caller needs to to cast the result anyway, and on top of that it hardcodes the module type to loader class mapping

 - Don't see why DeploymentContext and DeploymentMetaData are different

 - Don't like turning module types into integers for the ObjectName, and don't think this needs an interface

 - Don't see why the change to AbstractManagedObject is in here

---------------------------------------------------------------------
View the issue:

  http://jira.codehaus.org/secure/ViewIssue.jspa?key=GERONIMO-106


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: GERONIMO-106
    Summary: Deployment Planner base-class
       Type: Improvement

     Status: Assigned
   Priority: Major

 Time Spent: Unknown
  Remaining: Unknown

    Project: Apache Geronimo
 Components: 
             deployment

   Assignee: Aaron Mulder
   Reporter: Gianny DAMOUR

    Created: Tue, 21 Oct 2003 9:55 AM
    Updated: Tue, 21 Oct 2003 10:00 AM

Description:
This patch is an enhancement of GERONIMO-102, which was a "sample code" used to progress a discussion about the responsibities of Deployment Planners.

It should fix most of the drawbacks identified by Jan Bartel. Some points have not been fixed. Indeed, some of them require a significant impact of the code-base.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira