You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/02/21 07:47:52 UTC

[GitHub] codecov-io edited a comment on issue #4255: Improve container factory documentation

codecov-io edited a comment on issue #4255: Improve container factory documentation
URL: https://github.com/apache/incubator-openwhisk/pull/4255#issuecomment-461401061
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=h1) Report
   > Merging [#4255](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-openwhisk/commit/9eb197cdb60a72f67b8c8a7f81413cadc73d54de?src=pr&el=desc) will **increase** coverage by `21.18%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/graphs/tree.svg?width=650&token=l0YmsiSAso&height=150&src=pr)](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #4255       +/-   ##
   ===========================================
   + Coverage   59.79%   80.98%   +21.18%     
   ===========================================
     Files         163      163               
     Lines        7594     7594               
     Branches      502      502               
   ===========================================
   + Hits         4541     6150     +1609     
   + Misses       3053     1444     -1609
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...penwhisk/core/containerpool/ContainerFactory.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXJGYWN0b3J5LnNjYWxh) | `85.71% <ø> (ø)` | :arrow_up: |
   | [.../org/apache/openwhisk/core/entity/EntityPath.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0VudGl0eVBhdGguc2NhbGE=) | `100% <0%> (+1.88%)` | :arrow_up: |
   | [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `95.45% <0%> (+2.27%)` | :arrow_up: |
   | [.../org/apache/openwhisk/http/PoolingRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvUG9vbGluZ1Jlc3RDbGllbnQuc2NhbGE=) | `90% <0%> (+3.33%)` | :arrow_up: |
   | [...hisk/core/controller/actions/SequenceActions.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29yZS9jb250cm9sbGVyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udHJvbGxlci9hY3Rpb25zL1NlcXVlbmNlQWN0aW9ucy5zY2FsYQ==) | `92.1% <0%> (+3.5%)` | :arrow_up: |
   | [...pache/openwhisk/core/containerpool/Container.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9Db250YWluZXIuc2NhbGE=) | `88.6% <0%> (+3.79%)` | :arrow_up: |
   | [...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJBcnRpZmFjdFN0b3JlUHJvdmlkZXIuc2NhbGE=) | `4% <0%> (+4%)` | :arrow_up: |
   | [...tainerpool/docker/DockerClientWithFileAccess.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ2xpZW50V2l0aEZpbGVBY2Nlc3Muc2NhbGE=) | `96% <0%> (+4%)` | :arrow_up: |
   | [...rg/apache/openwhisk/core/entity/ExecManifest.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0V4ZWNNYW5pZmVzdC5zY2FsYQ==) | `97.87% <0%> (+4.25%)` | :arrow_up: |
   | [...he/openwhisk/core/database/CouchDbRestClient.scala](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvQ291Y2hEYlJlc3RDbGllbnQuc2NhbGE=) | `87.23% <0%> (+4.25%)` | :arrow_up: |
   | ... and [93 more](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=footer). Last update [9eb197c...c869f37](https://codecov.io/gh/apache/incubator-openwhisk/pull/4255?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services