You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2022/08/05 15:46:21 UTC

[Impala-ASF-CR] IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg tbl (col list)

lipenglin@sensorsdata.cn has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/18790 )

Change subject: IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list)
......................................................................

IMPALA-11408: Fill missing partition columns when INSERT INTO iceberg_tbl (col_list)

In the case of INSERT INTO iceberg_tbl (col_a, col_b, ...), if the
partition columns of Iceberg table are not in the columns permutation,
in order for data to be written to the default
partition '__HIVE_DEFAULT_PARTITION__' we will fill the missing
partition columns with NullLiteral.

Testing:
 - add e2e tests

Change-Id: I40c733755d65e5c81a12ffe09b6d16ed5d115368
---
M fe/src/main/java/org/apache/impala/analysis/InsertStmt.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-partitioned-insert.test
3 files changed, 165 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/90/18790/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18790
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I40c733755d65e5c81a12ffe09b6d16ed5d115368
Gerrit-Change-Number: 18790
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <li...@sensorsdata.cn>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>