[GitHub] trafficserver pull request #1608: FTP Support

[zwoop <gi...@git.apache.org>]

Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1608#discussion_r108462430
  
    --- Diff: proxy/http/HttpConfig.h ---
    @@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo {
     
       MgmtInt body_factory_response_max_size;
     
    +  MgmtByte forward_proxy_ftp_enabled;
    --- End diff --
    
    Can you move this up where other MgmtByte's are? That avoids unnecessary padding of the bytes (as it is above, you would waste at least 3 bytes in the struct).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---