You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/02/27 17:10:19 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3769: ArrayData Enumeration for Struct, List, Dictionary

tustvold commented on code in PR #3769:
URL: https://github.com/apache/arrow-rs/pull/3769#discussion_r1119039912


##########
arrow-data/src/data/bytes.rs:
##########
@@ -270,7 +270,7 @@ impl<O: BytesOffset, B: Bytes> BytesArrayData<O, B> {
 
     /// Returns the offsets
     #[inline]
-    pub fn value_offsets(&self) -> &[O] {
+    pub fn offsets(&self) -> &[O] {

Review Comment:
   The value_ prefix is redundant



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org