You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/04/08 06:42:51 UTC
[GitHub] flink pull request #5828: [FLINK-9147] [metrics] Include shaded Prometheus d...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/5828
[FLINK-9147] [metrics] Include shaded Prometheus dependencies in jar
## What is the purpose of the change
The Prometheus metrics reporter does not include the shaded Prometheus dependencies
in its jar. This commit changes this.
## Verifying this change
- Verified manually
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixPrometheusDependencies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5828.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5828
----
commit 1edc725bf6ef46ffe1ba9a6fabf343ec46ad52f2
Author: Till Rohrmann <tr...@...>
Date: 2018-04-08T06:40:42Z
[FLINK-9147] [metrics] Include shaded Prometheus dependencies in jar
The Prometheus metrics reporter does not include the shaded Prometheus dependencies
in its jar. This commit changes this.
----
---
[GitHub] flink issue #5828: [FLINK-9147] [metrics] Include shaded Prometheus dependen...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5828
+1
---
[GitHub] flink issue #5828: [FLINK-9147] [metrics] Include shaded Prometheus dependen...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5828
merging.
---
[GitHub] flink pull request #5828: [FLINK-9147] [metrics] Include shaded Prometheus d...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5828
---