You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Daniel Kulp (Jira)" <ji...@apache.org> on 2021/09/13 18:32:00 UTC
[jira] [Resolved] (AVRO-3150) Checkstyle requires LF line endings:
add .gitattributes hint
[ https://issues.apache.org/jira/browse/AVRO-3150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Kulp resolved AVRO-3150.
-------------------------------
Fix Version/s: 1.11.0
Assignee: Daniel Kulp
Resolution: Fixed
I changed the checkstyle rule instead to allow the various cr/lf endings. Not sure why it was restricted.
> Checkstyle requires LF line endings: add .gitattributes hint
> ------------------------------------------------------------
>
> Key: AVRO-3150
> URL: https://issues.apache.org/jira/browse/AVRO-3150
> Project: Apache Avro
> Issue Type: Improvement
> Components: java
> Affects Versions: 1.10.2
> Reporter: Ryan
> Assignee: Daniel Kulp
> Priority: Major
> Fix For: 1.11.0
>
>
> Running the Java unit tests on a Windows machine with the commonly configured git line ending configuration:
> {quote}{{git config --global core.autocrlf true}}
> {quote}
> Results in test failure of:
> {quote}{{NewlineAtEndOfFile: Expected line ending for file is LF(\n), but CRLF(\r\n) is detected.}}
> {quote}
> This is due to a checkstyle rule. If the unit tests require LF line endings then it would be helpful to add a .gitattributes file to automatically ensure the correct line endings are used on git clone.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)