You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/06/12 14:50:40 UTC

[PR] Fix asset events table title [airflow]

pierrejeambrun opened a new pull request, #51658:
URL: https://github.com/apache/airflow/pull/51658

   Display the `title` as the asset events header.
   
   If no title is displayed, default to the `AssetEvent` key.
   
   ### Before
   ![Screenshot 2025-06-12 at 16 42 29](https://github.com/user-attachments/assets/ce82509b-9e69-4c8c-8ac1-57e91b1b4b3c)
   ![Screenshot 2025-06-12 at 16 42 41](https://github.com/user-attachments/assets/81409dc2-4979-47c5-99f4-5db8d03f2fb0)
   ![Screenshot 2025-06-12 at 16 42 50](https://github.com/user-attachments/assets/4dd19ec0-f200-4292-bc7a-9a47d7cc82f3)
   
   
   ### After
   ![Screenshot 2025-06-12 at 16 40 31](https://github.com/user-attachments/assets/58374457-b351-4713-ae33-df92f3906701)
   
   ![Screenshot 2025-06-12 at 16 39 20](https://github.com/user-attachments/assets/7e62ea85-251d-4776-9048-326ede05ce89)
   ![Screenshot 2025-06-12 at 16 39 30](https://github.com/user-attachments/assets/86ac83bf-d13a-493d-88b2-7a80ffc53acd)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967235164

   I need to handle the pluralized part though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967222477

   We can't backport this since it includes translations


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun merged PR #51658:
URL: https://github.com/apache/airflow/pull/51658


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967319137

   Handled in last commit:
   ![Screenshot 2025-06-12 at 17 28 49](https://github.com/user-attachments/assets/1037687d-b351-4709-9bb9-07dcc082057c)
   ![Screenshot 2025-06-12 at 17 33 02](https://github.com/user-attachments/assets/d2937d11-825b-448f-8dbc-0c15b4f4695b)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967231125

   Edit: It's actually correctly done in `v3-0-test`, we are doing:
   ```js
   {pluralize(title ?? "Asset Event", data?.total_entries ?? 0, undefined, true)}
   ```
   
   Removing the backport label


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix asset events table title [airflow]

Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51658:
URL: https://github.com/apache/airflow/pull/51658#issuecomment-2967226488

   Updated, I'll backport this manually. (basically just use the `title` directly without accessing any translation hook)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org