[jira] [Commented] (THRIFT-3569) c_glib protocols do not check number of bytes read by transport

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143312#comment-15143312 ] 

ASF GitHub Bot commented on THRIFT-3569:
----------------------------------------

GitHub user cjmay opened a pull request:

    https://github.com/apache/thrift/pull/849

    THRIFT-3569 Add thrift_transport_read_all to facilitate large reads in c_glib

    Add a read_all method to the base transport class, following suit from the C++ library, and use it instead of the original read method in the protocol implementations.  This fixes a bug causing reads of large fields (e.g., string or binary fields) to fail, depending on the underlying transport and platform.  Test using a framed transport with a tiny frame size.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cjmay/thrift THRIFT-3569

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/849.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #849
    
----
commit 96172b11ac0608ae59ebea416a4cae1158195706
Author: Chandler May <cj...@gmail.com>
Date:   2016-02-11T13:25:25Z

    THRIFT-3569 Add thrift_transport_read_all to facilitate large reads in c_glib.

----


> c_glib protocols do not check number of bytes read by transport
> ---------------------------------------------------------------
>
>                 Key: THRIFT-3569
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3569
>             Project: Thrift
>          Issue Type: Bug
>          Components: C glib - Library
>    Affects Versions: 0.9.3
>            Reporter: Chandler May
>            Assignee: Chandler May
>
> I propose adding a read_all method to the thrift_transport interface with the obvious default implementation and using that.  This would facilitate implementation of other protocols.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)