You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/11/25 14:16:05 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5006: Gradle: Support for proxy detection / autoconfiguration.
sdedic opened a new pull request, #5006:
URL: https://github.com/apache/netbeans/pull/5006
On a corporate network or on a VPN the user often forgets about a network change - even worse because with PAC autoconfiguration, NetBeans IDE is able to dynamically change proxy / non-proxy, depending on PAC results.
But build tools like Gradle have to get explicit instructions. The user uses NetBeans, happilly browses online resources (with an PAC-configured browser), but build actions or even project info load itself fails mysteriously on missing on unreachable artifacts.
This PR adds a check, before taking an 'online' action in Gradle, if Gradle's configuration file matches IDE's own proxy settings. If it does not, the default is to suggest the user to reconfigure Gradle - and NetBeans will even do that for the user.
The user may also choose to leave settings as they are (for whatever reason), but let the IDE to instruct Gradle to use proxy for IDE-initiated operations. In this scenario, commandline actions will likely fail - but no persistent change in files need to be made.
A global Gradle setting is introduced to specify the preferred handling:
- **ask the user (the default)**
- do not check
- display a notice and override
- override using system properties
- automatically update
Old `gradle.properties` are always saved as `gradle.properties.old` (`gradle.properties.old.1`, ....) to preserve potential user content, although `EditableProperties` API is used to retain eventual user comments in the file.
The current implementation contains some cut-through path, since because of gradle/gradle#22856 I am able to define a proxy, if one is not defined at all, but the bug prevents me from **changing** or **removing** proxy settings on-the-fly in case the proxy is configured in the file, but the config is wrong.
Note: because of Vscode handling, the option to pass system properties ("Override" option) can be disabled by branding API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330570170
@sdedic you'll need to open a second PR, cherry picking these changes on top of `release160`, taking care of module versions if necessary.
@MartinBalin I'll liaise with you when we can start merging into the release branch - not until the existing votes are closed anyway!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1327892602
I would advise against that, but it is surely doable. In siuations where the DNS does not reject the proxy name immediately (timeout) or when the intranet simply drops (not rejects) outgoing packets, gradle app + network timeouts are huuuuuuge. It may take several to dozen minutes for the project load to fail.
It seemed safer + better user experience to hook before any non-offline operation and check in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330548314
I would appreciate if this PR could land in NB16u1-gradle (cc: @MartinBalin) -- in NB a misconfigured proxy is bad enough, but if the vscode environment is used with several lang servers all working against bad proxy/network configuration, it is a true hell on developer's machine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic merged pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
sdedic merged PR #5006:
URL: https://github.com/apache/netbeans/pull/5006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1330617715
@neilcsmith-net understood - but I'd like to get the code in here reviewed or sanity-checked first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
sdedic commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1339138643
@lkishalmi -- last call: there's sanity check from @dbalek, but this is your field of expertise, I'd feel more comfortable if I could get +-0 from you for this implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #5006: Gradle: Support for proxy detection / autoconfiguration.
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on PR #5006:
URL: https://github.com/apache/netbeans/pull/5006#issuecomment-1327680114
Would not be this better as a project problem provider with a resolution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists