You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Vitalyi Brodetskyi <vb...@hortonworks.com> on 2014/08/19 20:53:18 UTC
Review Request 24859: Start/Stop services fails after ambari upgrade
1.6.0->1.7.0, 1.6.1->1.7.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/
-----------------------------------------------------------
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-6919
https://issues.apache.org/jira/browse/AMBARI-6919
Repository: ambari
Description
-------
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
DataNode().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
tmp_dir = Script.get_tmp_dir()
AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
Diffs
-----
ambari-agent/conf/unix/install-helper.sh c2d2a3d
ambari-agent/pom.xml c98af34
ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
ambari-server/conf/unix/install-helper.sh dafe987
ambari-server/pom.xml 2ec71ab
ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
Diff: https://reviews.apache.org/r/24859/diff/
Testing
-------
Thanks,
Vitalyi Brodetskyi
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
> On Сер. 20, 2014, 9:49 до полудня, Andrew Onischuk wrote:
> >
These fixes should be provided in another ticket, which is already created.
- Vitalyi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/#review51084
-----------------------------------------------------------
On Сер. 19, 2014, 7:02 після полудня, Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24859/
> -----------------------------------------------------------
>
> (Updated Сер. 19, 2014, 7:02 після полудня)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-6919
> https://issues.apache.org/jira/browse/AMBARI-6919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
> DataNode().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
> import params
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
> tmp_dir = Script.get_tmp_dir()
> AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh c2d2a3d
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh dafe987
> ambari-server/pom.xml 2ec71ab
> ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24859/diff/
>
>
> Testing
> -------
>
> mvn test clean
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/#review51084
-----------------------------------------------------------
ambari-agent/conf/unix/install-helper.sh
<https://reviews.apache.org/r/24859/#comment89051>
We should make sure if it's a link before deleting not to face issues when updating FROM 1.7.0.
We can create a separate issue for that. Please confirm if it's so.
ambari-server/conf/unix/install-helper.sh
<https://reviews.apache.org/r/24859/#comment89052>
The same here for both common_dir and resource_management_dir
- Andrew Onischuk
On Aug. 19, 2014, 7:02 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24859/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 7:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-6919
> https://issues.apache.org/jira/browse/AMBARI-6919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
> DataNode().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
> import params
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
> tmp_dir = Script.get_tmp_dir()
> AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh c2d2a3d
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh dafe987
> ambari-server/pom.xml 2ec71ab
> ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24859/diff/
>
>
> Testing
> -------
>
> mvn test clean
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/#review51087
-----------------------------------------------------------
Ship it!
Ship It!
- Andrew Onischuk
On Aug. 19, 2014, 7:02 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24859/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 7:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-6919
> https://issues.apache.org/jira/browse/AMBARI-6919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
> DataNode().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
> import params
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
> tmp_dir = Script.get_tmp_dir()
> AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh c2d2a3d
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh dafe987
> ambari-server/pom.xml 2ec71ab
> ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24859/diff/
>
>
> Testing
> -------
>
> mvn test clean
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/#review51032
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On Aug. 19, 2014, 7:02 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24859/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 7:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-6919
> https://issues.apache.org/jira/browse/AMBARI-6919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
> DataNode().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
> import params
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
> tmp_dir = Script.get_tmp_dir()
> AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh c2d2a3d
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh dafe987
> ambari-server/pom.xml 2ec71ab
> ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24859/diff/
>
>
> Testing
> -------
>
> mvn test clean
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/#review51036
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 19, 2014, 3:02 p.m., Vitalyi Brodetskyi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24859/
> -----------------------------------------------------------
>
> (Updated Aug. 19, 2014, 3:02 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
>
>
> Bugs: AMBARI-6919
> https://issues.apache.org/jira/browse/AMBARI-6919
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Traceback (most recent call last):
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
> DataNode().execute()
> File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
> import params
> File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
> tmp_dir = Script.get_tmp_dir()
> AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
>
>
> Diffs
> -----
>
> ambari-agent/conf/unix/install-helper.sh c2d2a3d
> ambari-agent/pom.xml c98af34
> ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
> ambari-server/conf/unix/install-helper.sh dafe987
> ambari-server/pom.xml 2ec71ab
> ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
>
> Diff: https://reviews.apache.org/r/24859/diff/
>
>
> Testing
> -------
>
> mvn test clean
>
>
> Thanks,
>
> Vitalyi Brodetskyi
>
>
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/
-----------------------------------------------------------
(Updated Сер. 19, 2014, 7:02 після полудня)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-6919
https://issues.apache.org/jira/browse/AMBARI-6919
Repository: ambari
Description
-------
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
DataNode().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
tmp_dir = Script.get_tmp_dir()
AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
Diffs
-----
ambari-agent/conf/unix/install-helper.sh c2d2a3d
ambari-agent/pom.xml c98af34
ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
ambari-server/conf/unix/install-helper.sh dafe987
ambari-server/pom.xml 2ec71ab
ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
Diff: https://reviews.apache.org/r/24859/diff/
Testing (updated)
-------
mvn test clean
Thanks,
Vitalyi Brodetskyi
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/
-----------------------------------------------------------
(Updated Сер. 19, 2014, 6:57 після полудня)
Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Jonathan Hurley.
Bugs: AMBARI-6919
https://issues.apache.org/jira/browse/AMBARI-6919
Repository: ambari
Description
-------
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
DataNode().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
tmp_dir = Script.get_tmp_dir()
AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
Diffs
-----
ambari-agent/conf/unix/install-helper.sh c2d2a3d
ambari-agent/pom.xml c98af34
ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
ambari-server/conf/unix/install-helper.sh dafe987
ambari-server/pom.xml 2ec71ab
ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
Diff: https://reviews.apache.org/r/24859/diff/
Testing
-------
doing it now
Thanks,
Vitalyi Brodetskyi
Re: Review Request 24859: Start/Stop services fails after ambari
upgrade 1.6.0->1.7.0, 1.6.1->1.7.0.
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24859/
-----------------------------------------------------------
(Updated Сер. 19, 2014, 6:53 після полудня)
Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley.
Bugs: AMBARI-6919
https://issues.apache.org/jira/browse/AMBARI-6919
Repository: ambari
Description
-------
Traceback (most recent call last):
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 59, in <module>
DataNode().execute()
File "/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py", line 111, in execute
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/datanode.py", line 40, in stop
import params
File "/var/lib/ambari-agent/cache/stacks/HDP/2.0.6/services/HDFS/package/scripts/params.py", line 25, in <module>
tmp_dir = Script.get_tmp_dir()
AttributeError: type object 'Script' has no attribute 'get_tmp_dir'
Diffs
-----
ambari-agent/conf/unix/install-helper.sh c2d2a3d
ambari-agent/pom.xml c98af34
ambari-agent/src/main/package/rpm/posttrans_agent.sh PRE-CREATION
ambari-server/conf/unix/install-helper.sh dafe987
ambari-server/pom.xml 2ec71ab
ambari-server/src/main/package/rpm/posttrans_server.sh PRE-CREATION
Diff: https://reviews.apache.org/r/24859/diff/
Testing (updated)
-------
doing it now
Thanks,
Vitalyi Brodetskyi