You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/25 15:20:08 UTC
Review Request 71814: WIP: Added support for 'http+unix' URL scheme in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Bugs: MESOS-10039
https://issues.apache.org/jira/browse/MESOS-10039
Repository: mesos
Description
-------
Added support for a new 'http+unix' URL scheme, to denote
resources accessible by HTTP connections over unix domain
sockets.
The encoding looks like
http+unix://<url-encoded filesystem path>/<http path>
optionally followed by query and fragment sections.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2
3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
Diff: https://reviews.apache.org/r/71814/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71814: Added support for new 'http+unix' URL
scheme in libprocess.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/#review219208
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Dec. 3, 2019, 7:27 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71814/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2019, 7:27 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10039
> https://issues.apache.org/jira/browse/MESOS-10039
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for a new 'http+unix' URL scheme, to denote
> resources accessible by HTTP connections over unix domain
> sockets.
>
> The encoding looks like
>
> http+unix://<url-encoded filesystem path>/<http path>
>
> optionally followed by query and fragment sections.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2
> 3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
>
>
> Diff: https://reviews.apache.org/r/71814/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 71814: Added support for new 'http+unix' URL
scheme in libprocess.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/
-----------------------------------------------------------
(Updated Dec. 3, 2019, 6:27 p.m.)
Review request for mesos, Benjamin Bannier and Benjamin Mahler.
Changes
-------
Some cleanup; experimentally removing windows ifdefs.
Summary (updated)
-----------------
Added support for new 'http+unix' URL scheme in libprocess.
Bugs: MESOS-10039
https://issues.apache.org/jira/browse/MESOS-10039
Repository: mesos
Description
-------
Added support for a new 'http+unix' URL scheme, to denote
resources accessible by HTTP connections over unix domain
sockets.
The encoding looks like
http+unix://<url-encoded filesystem path>/<http path>
optionally followed by query and fragment sections.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2
3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
Diff: https://reviews.apache.org/r/71814/diff/2/
Changes: https://reviews.apache.org/r/71814/diff/1-2/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 71814: WIP: Added support for 'http+unix' URL
scheme in libprocess.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71814/#review218788
-----------------------------------------------------------
Hm.. it doesn't seem like this should be done in the scheme. Is this http+unix scheme part of an RFC? https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
Have you looked at how other libraries / tools do this?
One example I see is with additional options struct / argument / connection and listener related abstractions:
node.js: https://stackoverflow.com/a/42388725/10808639
curl: https://superuser.com/a/925610
golang: https://gist.github.com/teknoraver/5ffacb8757330715bcbcc90e6d46ac74
- Benjamin Mahler
On Nov. 25, 2019, 3:20 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71814/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2019, 3:20 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Benjamin Mahler.
>
>
> Bugs: MESOS-10039
> https://issues.apache.org/jira/browse/MESOS-10039
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added support for a new 'http+unix' URL scheme, to denote
> resources accessible by HTTP connections over unix domain
> sockets.
>
> The encoding looks like
>
> http+unix://<url-encoded filesystem path>/<http path>
>
> optionally followed by query and fragment sections.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp 0013850f07110d9b9dbdb9b0c8ac7001a82420d2
> 3rdparty/libprocess/src/http.cpp b487ce214128193a3443f4e62a5af24205cbd399
>
>
> Diff: https://reviews.apache.org/r/71814/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>