[GitHub] [cordova-android] timbru31 commented on a change in pull request #928: Update check_reqs.js - allow JDK > 1.8

[GitBox <gi...@apache.org>]

timbru31 commented on a change in pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#discussion_r441154076



##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -393,11 +393,13 @@ module.exports.run = function () {
         console.log('ANDROID_SDK_ROOT=' + process.env['ANDROID_SDK_ROOT'] + ' (recommended setting)');
         console.log('ANDROID_HOME=' + process.env['ANDROID_HOME'] + ' (DEPRECATED)');
 
-        if (!String(values[0]).startsWith('1.8.')) {
+        if (values[0] === undefined) {

Review comment:
       The problem is that in Java <=1.8 it’s labeled as `1.x` while Java 9 and newer dropped the `1.`. This complicates the check a little bit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org