You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:32:32 UTC
[GitHub] [qpid-dispatch] ganeshmurthy opened a new pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
ganeshmurthy opened a new pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108
…ingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#issuecomment-815250624
Oooh boy - HTTP1 tests don't see to be too happy with these changes...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#issuecomment-815275923
> Oooh boy - HTTP1 tests don't see to be too happy with these changes...
I saw several "OSError: [Errno 98] Address already in use" errors and assumed those had to do with https://issues.apache.org/jira/browse/DISPATCH-1986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ChugR commented on a change in pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
ChugR commented on a change in pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#discussion_r608844613
##########
File path: src/buffer.c
##########
@@ -24,8 +24,8 @@
#include <stdint.h>
#include <string.h>
-
-size_t BUFFER_SIZE = 512;
+// BUFFER_SIZE is set to 4k
Review comment:
"size_t BUFFER_SIZE = 4096;"
stands pretty well on its own and does not need a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on a change in pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on a change in pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#discussion_r609051584
##########
File path: tests/run_unit_tests_size.c
##########
@@ -45,7 +45,7 @@ int main(int argc, char** argv)
qd_buffer_set_size(buffer_size);
int result = 0;
- result += message_tests();
+ result += message_tests(buffer_size);
Review comment:
should the default buffer size be updated on line 34 above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy commented on a change in pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
ganeshmurthy commented on a change in pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#discussion_r608876343
##########
File path: src/buffer.c
##########
@@ -24,8 +24,8 @@
#include <stdint.h>
#include <string.h>
-
-size_t BUFFER_SIZE = 512;
+// BUFFER_SIZE is set to 4k
Review comment:
Removed comment, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] kgiusti commented on pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
kgiusti commented on pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108#issuecomment-815247415
There's some test failures that might be relying on the 512 buffer size.
https://github.com/apache/qpid-dispatch/blob/main/tests/system_tests_one_router.py#L3577
Also we need to add a 4096 test case here:
https://github.com/apache/qpid-dispatch/blob/main/tests/CMakeLists.txt#L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-dispatch] ganeshmurthy closed pull request #1108: NO-JIRA-YET: Set the buffer size to 4k. Also adjusts Q2 and Q3 accord…
Posted by GitBox <gi...@apache.org>.
ganeshmurthy closed pull request #1108:
URL: https://github.com/apache/qpid-dispatch/pull/1108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org