[GitHub] [spark] cloud-fan commented on a change in pull request #35459: [SPARK-38159] Minor refactor of MetadataAttribute unapply method

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35459:
URL: https://github.com/apache/spark/pull/35459#discussion_r802657981



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
##########
@@ -437,16 +437,20 @@ object VirtualColumn {
  * The internal representation of the hidden metadata struct:
  * set `__metadata_col` to `true` in AttributeReference metadata
  * - apply() will create a metadata attribute reference
- * - unapply() will check if an attribute reference is the metadata attribute reference
+ * - unapply() will check if an attribute reference is the file source metadata attribute reference
  */
 object MetadataAttribute {

Review comment:
       Maybe we should have two objects
   1. `MetadataAttribute`: This is used to create and extract general metadata attributes (not only for file source)
   2. `FileSourceMetadataAttribute`: To extract file source metadata attributes




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org