You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/01 03:47:20 UTC

[GitHub] [incubator-seatunnel] dongzl opened a new pull request #915: Fixes class logger variable name, keep the same with other class file.

dongzl opened a new pull request #915:
URL: https://github.com/apache/incubator-seatunnel/pull/915


   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[SeaTunnel #XXXX] [component] Title of the pull request", where *SeaTunnel #XXXX* should be replaced by the actual issue number.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   Fixes class logger variable name, keep the same with other class file.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #915: Fixes class logger variable name, keep the same with other class file.

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on pull request #915:
URL: https://github.com/apache/incubator-seatunnel/pull/915#issuecomment-1003547488


   Thank you for your contribution, and look forward to your next contribution.
   btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] dongzl commented on pull request #915: Fixes class logger variable name, keep the same with other class file.

Posted by GitBox <gi...@apache.org>.
dongzl commented on pull request #915:
URL: https://github.com/apache/incubator-seatunnel/pull/915#issuecomment-1003552979


   > Thank you for your contribution, and look forward to your next contribution. btw, I prefer @slf4j to reduce unnecessary code. But this needs to be discussed, let's talk about this later.
   
   Hi @CalvinKirs , Thanks for you reply, `@slf4j` is a good tools.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #915: Fixes class logger variable name, keep the same with other class file.

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #915:
URL: https://github.com/apache/incubator-seatunnel/pull/915


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org