You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "xiaoxiangyeyu0 (via GitHub)" <gi...@apache.org> on 2025/10/17 11:01:51 UTC

[PR] bugfix:fix https://github.com/apache/incubator-seata/issues/7690 [incubator-seata]

xiaoxiangyeyu0 opened a new pull request, #7708:
URL: https://github.com/apache/incubator-seata/pull/7708

   <!--
       Licensed to the Apache Software Foundation (ASF) under one or more
       contributor license agreements.  See the NOTICE file distributed with
       this work for additional information regarding copyright ownership.
       The ASF licenses this file to You under the Apache License, Version 2.0
       (the "License"); you may not use this file except in compliance with
       the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
       
       Unless required by applicable law or agreed to in writing, software
       distributed under the License is distributed on an "AS IS" BASIS,
       WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
       See the License for the specific language governing permissions and
       limitations under the License.
   -->
   <!-- Please make sure you have read and understood the contributing guidelines -->
   
   - [ ] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
   - [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
   
   ### Ⅰ. Describe what this PR did
   
   
   ### Ⅱ. Does this pull request fix one issue?
   <!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
   fix https://github.com/apache/incubator-seata/issues/7690
   
   ### Ⅲ. Why don't you add test cases (unit test/integration test)? 
   
   
   ### Ⅳ. Describe how to verify it
   
   
   ### Ⅴ. Special notes for reviews
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix:Use xaActive to determine whether xaResource needs to execute the end method [incubator-seata]

Posted by "xiaoxiangyeyu0 (via GitHub)" <gi...@apache.org>.
xiaoxiangyeyu0 commented on PR #7708:
URL: https://github.com/apache/incubator-seata/pull/7708#issuecomment-3421319842

   如下测试场景通过
   1、pg数据库,加上@GlobalTransactional,正常提交事务成功。
   2、pg数据库,加上@GlobalTransactional,报错回滚成功。
   3、pg数据库,加上@GlobalTransactional,超时回滚成功。
   4、pg数据库,加上@GlobalTransactional和@Transactional注解,正常提交事务成功。
   5、pg数据库,加上@GlobalTransactional和@Transactional注解,报错回滚成功。
   6、pg数据库,加上@GlobalTransactional和@Transactional注解,超时回滚成功。
   7、mysql5.7数据库,加上@GlobalTransactional,正常提交事务成功。
   8、mysql5.7数据库,加上@GlobalTransactional,报错回滚成功。
   9、mysql5.7数据库,加上@GlobalTransactional,超时回滚成功。
   10、mysql5.7数据库,加上@GlobalTransactional和@Transactional注解,正常提交事务成功。
   11、mysql5.7数据库,加上@GlobalTransactional和@Transactional注解,报错回滚成功。
   12、mysql5.7数据库,加上@GlobalTransactional和@Transactional注解,超时回滚成功。
   The following test scenarios passed successfully:
   
   1. In the PostgreSQL database, adding the `@GlobalTransactional` annotation resulted in a successful, normal transaction commit.
   2. Again in the PostgreSQL database, applying `@GlobalTransactional` led to an error, but the rollback was executed successfully.
   3. Still in PostgreSQL, when `@GlobalTransactional` was combined with a timeout setting, the rollback occurred as expected.
   4. In the PostgreSQL database, using both `@GlobalTransactional` and the `@Transactional` annotation allowed for a successful, normal transaction commit.
   5. In PostgreSQL, combining `@GlobalTransactional` with `@Transactional` triggered an error, yet the rollback proceeded without issues.
   6. Once more in PostgreSQL, integrating `@GlobalTransactional` along with `@Transactional` and introducing a timeout caused the rollback to complete successfully.
   7. In the MySQL 5.7 database, adding the `@GlobalTransactional` annotation resulted in a successful, normal transaction commit.
   8. In MySQL 5.7, incorporating `@GlobalTransactional` led to an error, but the rollback was handled successfully.
   9. Also in MySQL 5.7, when `@GlobalTransactional` was used alongside a timeout, the rollback completed as expected.
   10. In the MySQL 5.7 database, employing both `@GlobalTransactional` and `@Transactional` annotations enabled a successful, normal transaction commit.
   11. In MySQL 5.7, combining `@GlobalTransactional` with `@Transactional` caused an error, though the rollback was still executed successfully.
   12. Finally, in MySQL 5.7, using `@GlobalTransactional` with `@Transactional` and a timeout setting resulted in a successful rollback.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix:Use xaActive to determine whether xaResource needs to execute the end method [incubator-seata]

Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7708:
URL: https://github.com/apache/incubator-seata/pull/7708


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix:fix https://github.com/apache/incubator-seata/issues/7690 [incubator-seata]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7708:
URL: https://github.com/apache/incubator-seata/pull/7708#issuecomment-3415062266

   ## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7708?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 61.53%. Comparing base ([`9b97559`](https://app.codecov.io/gh/apache/incubator-seata/commit/9b97559e032585d0d8c896273125f1d8fea476b5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`cff37a0`](https://app.codecov.io/gh/apache/incubator-seata/commit/cff37a0a52cb19fe05c39ec5dbdc7ddabbc3fe12?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##                2.x    #7708      +/-   ##
   ============================================
   + Coverage     61.41%   61.53%   +0.11%     
   + Complexity      682      680       -2     
   ============================================
     Files          1324     1324              
     Lines         50047    50045       -2     
     Branches       5910     5910              
   ============================================
   + Hits          30738    30796      +58     
   + Misses        16531    16447      -84     
   - Partials       2778     2802      +24     
   ```
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7708?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ache/seata/rm/datasource/xa/ConnectionProxyXA.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7708?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2Fxa%2FConnectionProxyXA.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS94YS9Db25uZWN0aW9uUHJveHlYQS5qYXZh) | `48.48% <100.00%> (-0.52%)` | :arrow_down: |
   
   ... and [43 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/incubator-seata/pull/7708/graphs/tree.svg?width=650&height=150&src=pr&token=tbmHt2ZfxO&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/incubator-seata/pull/7708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org


Re: [PR] bugfix:Use xaActive to determine whether xaResource needs to execute the end method [incubator-seata]

Posted by "xiaoxiangyeyu0 (via GitHub)" <gi...@apache.org>.
xiaoxiangyeyu0 commented on PR #7708:
URL: https://github.com/apache/incubator-seata/pull/7708#issuecomment-3421315390

   > PRs need to be registered, and the title must clearly describe the change — not just be an issue link.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org