[GitHub] [activemq] gemmellr commented on a change in pull request #712: [AMQ-8385] Update to target-version for JDK 11

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #712:
URL: https://github.com/apache/activemq/pull/712#discussion_r713238474



##########
File path: pom.xml
##########
@@ -115,8 +115,8 @@
     <felix-framework-version>5.6.12</felix-framework-version>
 
     <site-repo-url>scpexe://people.apache.org/www/activemq.apache.org/maven/</site-repo-url>
-    <source-version>1.8</source-version>
-    <target-version>1.8</target-version>
+    <source-version>8</source-version>

Review comment:
       I am guessing either just because no 11-level source features are actually being used yet, or alternatively perhaps some things actually start failing to compile if it is bumped, even if they do work when its already targetting 11, because the compiler it starts enforcing some things it didnt while source level remains set to 8. (That happened with the changes I did for Artemis, 8+11 worked, 11+11 needed changes).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org