[jira] Commented: (WINK-99) Use Wink Client instead of Apaceh Http Client in integration tests

["Bryant Luk (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WINK-99?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731414#action_12731414 ] 

Bryant Luk commented on WINK-99:
--------------------------------

How about eventually duplicating the tests to use the Wink Client (i.e. one test suite / class uses Apache Commons Http Client and another Wink Client which do the same thing)?  Since the work is already being done with HttpClient, I don't see any harm in keeping the existing tests as is.  This would also help eliminate any issues that might be hiding in both the Wink server and client which we might not catch with a "third party" client being used (i.e. interoperability testing).

I think the server side component is where the preliminary interest will be in, and I don't think we want to confuse the issue with client issues until we know that the server side piece works.  Also, we haven't really had a design discussion on the client itself.

>i would prefer that the person that will perform this switch is the one that is not familiar with Wink Client API.

I think this is a good idea, and I expect some design decisions to be discussed on the mailing list from that as well.

> Use Wink Client instead of Apaceh Http Client in integration tests
> ------------------------------------------------------------------
>
>                 Key: WINK-99
>                 URL: https://issues.apache.org/jira/browse/WINK-99
>             Project: Wink
>          Issue Type: Task
>          Components: Testsuite
>    Affects Versions: 0.1
>            Reporter: Martin Snitkovsky
>             Fix For: 0.1
>
>
> Currently, integration tests are using Apache Commons Http Client. I think we should switch to Wink Client instead.
> I everyone agrees with this change, i would prefer that the person that will perform this switch is the one that is not familiar with Wink Client API.
> NOTE for issue assignee: 
> Wink client has an integration with Apache Http Client (wink-client-apache-httpclient module), so some of tests should use Wink Client + Apache Client instead of default Wink client that uses HttpUrlConnection.
> {code}
>        // create the client that uses Apache DefaultHttpClient as underling Http client. 
>        RestClient client = new RestClient(new ApacheHttpClientConfig(new DefaultHttpClient()));
>        
>        // create the resource to make invocations on
>        Resource resource = client.resource("http://myhost:80/my/service");
>        
>        // invoke GET on the resource and receive the response entity as a string
>        String entity = resource.get(String.class);
> {code}
>  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.