[jira] [Issue Comment Edited] (WW-3655) Freemarker result loads request uri as template

["Lukasz Lenart (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057740#comment-13057740 ] 

Lukasz Lenart edited comment on WW-3655 at 6/30/11 2:10 PM:
------------------------------------------------------------

I was thinking about something like this, we have an action as below in namespace /app

        <action name="index" class="org.demo.IndexAction">
            <result type="freemarker"/>
        </action>

so the result will be resolved to:

*/app/index.ftl*

or

*/app/index-success.ftl* (as success is the default result name)

if the result name will be specified

        <action name="index" class="org.demo.IndexAction">
            <result name="error" type="freemarker"/>
        </action>

the result would be:

*/app/index-error.ftl*

Could you check if is doable ?

      was (Author: lukaszlenart):
    I was thinking about something like this, we have an action as below in namespace /app

        <action name="index" class="org.demo.IndexAction">
            <result type="freemarker"/>
        </action>

so the result will be resolved to:

/app/index.ftl

or

/app/index-success.ftl (as success is the default result name)

if the result name will be specified

        <action name="index" class="org.demo.IndexAction">
            <result name="error" type="freemarker"/>
        </action>

the result would be:

/app/index-error.ftl

Could you check if is doable ?
  
> Freemarker result loads request uri as template
> -----------------------------------------------
>
>                 Key: WW-3655
>                 URL: https://issues.apache.org/jira/browse/WW-3655
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.2.3
>            Reporter: Johno Crawford
>            Assignee: Maurizio Cucchiara
>
> If the template location is either null or an empty string "" FreemarkerResult will take the request uri org.apache.struts2.views.freemarker.FreemarkerResult#doExecute and load it as a template.
> Example url, http://localhost:8080/com/acme/actions/Action.class/ would load /com/acme/actions/Action.class/ as a template and dump the bytecode in the response.
> The "feature" / culprit below seems a little exotic, however someone may be relying on it.. (same actions handling stuff in different directories?)
> if (!locationArg.startsWith("/")) {
>             String base = ResourceUtil.getResourceBase(req);
>             locationArg = base + "/" + locationArg;
> }
> To mitigate the problem and maintain previous functionality we could throw an exception if the template location is empty, I have created a pull request with my proposed fix https://github.com/apache/struts2/pull/1

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira