You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/06/29 14:36:57 UTC

[GitHub] flink pull request #2184: [FLINK-3618] [gelly] Rename abstract UDF classes i...

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2184

    [FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather implementation

    Rename MessageFunction to ScatterFunction and VertexUpdateFunction to GatherFunction.
        
    Change the parameter order in Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction) to Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 3618_rename_abstract_udf_classes_in_scatter_gather_implementation

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2184.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2184
    
----
commit 9dd51074104184a5cb6e69affa5775a91de4d9a4
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-05-06T19:39:38Z

    [FLINK-3618] [gelly] Rename abstract UDF classes in Scatter-Gather implementation
    
    Rename MessageFunction to ScatterFunction
    and VertexUpdateFunction to GatherFunction.
    
    Change the parameter order in
      Graph.runScatterGatherIteration(VertexUpdateFunction, MessagingFunction)
    to
      Graph.runScatterGatherIteration(ScatterFunction, GatherFunction)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2184: [FLINK-3618] [gelly] Rename abstract UDF classes in Scatt...

Posted by vasia <gi...@git.apache.org>.

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2184
  
    Thanks for the update @greghogan! +1 to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2184: [FLINK-3618] [gelly] Rename abstract UDF classes in Scatt...

Posted by vasia <gi...@git.apache.org>.

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2184
  
    Thanks a lot @greghogan. Everything looks good. Can you please update the docs too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2184: [FLINK-3618] [gelly] Rename abstract UDF classes i...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2184


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---