You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:51:21 UTC
[GitHub] [arrow] rymurr opened a new pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
rymurr opened a new pull request #7270:
URL: https://github.com/apache/arrow/pull/7270
This enables integration tests for extension types after custom metadata is fixed #7269
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #7270:
URL: https://github.com/apache/arrow/pull/7270
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-635432379
I think we can enable it and if we later decide we want to rework the implementation or API, this will give us a baseline to compare with.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-633682544
https://issues.apache.org/jira/browse/ARROW-8485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-635416459
@rymurr I admit I've completely forgotten what my complaint was :joy: Have you or anyone else been using it? I'd only be worried if it seemed like the feature wasn't being used at all.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-635534134
I'll leave this up for a bit before merging so others can look, but otherwise this is exciting!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rymurr commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-635418719
I am not using it, just trying to clean up some of the outstanding integration tests before the v1.0.0 release. This particular integration test requires no changes to the extension type vector so it does give me confidence in Extension types in that they are compatible w/ C++ IPC. However perhaps there is a way to mark the type as working but not extensively tested?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rymurr commented on pull request #7270: ARROW-8485: [Integration][Java] Implement extension types integration
Posted by GitBox <gi...@apache.org>.
rymurr commented on pull request #7270:
URL: https://github.com/apache/arrow/pull/7270#issuecomment-635415090
@lidavidm you mentioned previously you weren't totally happy with the existing implementation of extension types in Java. Is that still the case and is it wise to explicitly enable in integration if the data type isn't ready?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org