You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2022/12/12 09:27:22 UTC
[GitHub] [couchdb] big-r81 opened a new pull request, #4301: Fix rendering of inline literal with withespaces
big-r81 opened a new pull request, #4301:
URL: https://github.com/apache/couchdb/pull/4301
Fixed wrong rendering of an inline literal with whitespaces.
Use `:literal` as workaround, with escaping whitespaces `\ ` and added non-breakable-whitespace char (U+00A0)
## Overview
Before commit:
After commit:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 commented on a diff in pull request #4301: Fix rendering of inline literal with withespaces
Posted by GitBox <gi...@apache.org>.
big-r81 commented on code in PR #4301:
URL: https://github.com/apache/couchdb/pull/4301#discussion_r1046093441
##########
src/couch/src/couch_os_process.erl:
##########
@@ -157,6 +157,7 @@ init([Command, Options, PortOptions]) ->
couch_io_logger:start(os:getenv("COUCHDB_IO_LOG_DIR")),
PrivDir = couch_util:priv_dir(),
Spawnkiller = "\"" ++ filename:join(PrivDir, "couchspawnkillable") ++ "\"",
+ couch_log:info("OS Process Start (command):: ~p", [Command]),
Review Comment:
Oh yes, done a `git commit -a ...` without thinking...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] big-r81 merged pull request #4301: Fix rendering of inline literal with withespaces
Posted by GitBox <gi...@apache.org>.
big-r81 merged PR #4301:
URL: https://github.com/apache/couchdb/pull/4301
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] nickva commented on a diff in pull request #4301: Fix rendering of inline literal with withespaces
Posted by GitBox <gi...@apache.org>.
nickva commented on code in PR #4301:
URL: https://github.com/apache/couchdb/pull/4301#discussion_r1046068872
##########
src/couch/src/couch_os_process.erl:
##########
@@ -157,6 +157,7 @@ init([Command, Options, PortOptions]) ->
couch_io_logger:start(os:getenv("COUCHDB_IO_LOG_DIR")),
PrivDir = couch_util:priv_dir(),
Spawnkiller = "\"" ++ filename:join(PrivDir, "couchspawnkillable") ++ "\"",
+ couch_log:info("OS Process Start (command):: ~p", [Command]),
Review Comment:
This might be a stray / accidental log line ;-)
Though not a bad idea but in a different PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org