You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/09/03 11:25:12 UTC
[GitHub] [hadoop-ozone] rakeshadr opened a new pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
rakeshadr opened a new pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385
## What changes were proposed in this pull request?
Similar to OzoneManagerFS#lookupFile(OmKeyArgs args, String clientAddress) interface, "clientAddress" has been passed as an argument to OzoneManagerFS#listStatus(), OzoneManagerFS#getFileStatus() APIs.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3947
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
Used existing TestKeyManagerImpl unit test cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#issuecomment-693775540
> Thanks @rakeshadr for working on this. The patch LGTM, +1.
Thanks a lot @xiaoyuyao for the reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483645101
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1783,7 +1802,9 @@ private OzoneFileStatus getOzoneFileStatus(String volumeName,
// if the key is a file then do refresh pipeline info in OM by asking SCM
if (fileKeyInfo != null) {
- refreshPipeline(fileKeyInfo);
+ if (refreshPipeline) {
Review comment:
Thanks @adoroszlai again for the review help.
Yes, you are correct. Test passed locally without the `if (refreshPipeline)` condition.
Point-1) That means, the caller should call`refreshPipeline(OmKeyInfo value)` method without the `refreshPipeline` condition.
Point-2) Also, I'm planning to move the [refreshPipeline](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L2131) call outside BUCKET_LOCK and will be moving to [here](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L2147). Now, its a duplicate call added as part of HDDS-3658.
Does these two changes make sense to you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483727870
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
@adoroszlai , Sorry for re-opening the discussion on this comment. On a second thought `listStatus` is only used in [one place in the source code](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L2910) and there won't be any other caller for `listStatus() without ClientAddress`. So, how about deleting the original method and can add it later if there is any need ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483453091
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1783,7 +1802,9 @@ private OzoneFileStatus getOzoneFileStatus(String volumeName,
// if the key is a file then do refresh pipeline info in OM by asking SCM
if (fileKeyInfo != null) {
- refreshPipeline(fileKeyInfo);
+ if (refreshPipeline) {
Review comment:
I think `refreshPipeline` condition was removed intentionally in HDDS-3658 and should not be restored. (This is also causing failure of `TestKeyManagerUnit.testLookupFileWithDnFailure` unit test.)
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
In my [comment](https://github.com/apache/hadoop-ozone/pull/1192#discussion_r481025587) on the previous PR:
> Should we also keep the two original methods?
I meant both `getFileStatus` and `listStatus`. Sorry if it was unclear.
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -2144,10 +2166,14 @@ private void listStatusFindKeyInTableCache(
metadataManager.getLock().releaseReadLock(BUCKET_LOCK, volumeName,
bucketName);
}
- if (args.getRefreshPipeline()) {
- for(OzoneFileStatus fileStatus : fileStatusList){
+
+ for (OzoneFileStatus fileStatus : fileStatusList) {
+ if (args.getRefreshPipeline()) {
Review comment:
@ChenSammi Was this instance of `getRefreshPipeline` condition retained in HDDS-3658 intentionally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#issuecomment-694874767
Thanks @rakeshadr for the contribution, and @xiaoyuyao for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483727870
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
Sorry for re-opening the discussion on this comment. On a second thought `listStatus` is only used in [one place in the source code](https://github.com/apache/hadoop-ozone/blob/master/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java#L2910) and there won't be any other caller for `listStatus() without ClientAddress`. So, how about deleting the original method and can add it later if there is any need ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai merged pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
adoroszlai merged pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r488517426
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
> listStatus is only used in one place in the source code
It is also used by several tests, which all pass `null` as address.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#issuecomment-693298296
Thanks @adoroszlai for the reviews. Uploaded new commit addressing your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483645522
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
Sure, I will make the changes in my next commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r489309204
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/fs/OzoneManagerFS.java
##########
@@ -49,6 +69,21 @@ OpenKeySession createFile(OmKeyArgs args, boolean isOverWrite,
*/
OmKeyInfo lookupFile(OmKeyArgs args, String clientAddress) throws IOException;
+ /**
+ * List the status for a file or a directory and its contents.
+ *
+ * @param keyArgs the args of the key provided by client.
+ * @param recursive For a directory if true all the descendants of a
+ * particular directory are listed
+ * @param startKey Key from which listing needs to start. If startKey
+ * exists its status is included in the final list.
+ * @param numEntries Number of entries to list from the start key
+ * @param clientAddress a hint to key manager, order the datanode in returned
+ * pipeline by distance between client and datanode.
+ * @return list of file status
+ * @throws IOException if file or bucket or volume does not exist
+ */
List<OzoneFileStatus> listStatus(OmKeyArgs keyArgs, boolean recursive,
- String startKey, long numEntries) throws IOException;
+ String startKey, long numEntries, String clientAddress)
Review comment:
OK, addressed in my new commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#issuecomment-693775383
> Thanks @rakeshadr for updating the patch.
>
> I have one question left: shouldn't `getFileStatus` call from `listStatus` pass `clientAddress`?
>
> https://github.com/apache/hadoop-ozone/blob/088e40d2f79ab0e8c6021523fd4e2b8db23127af/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java#L2076
Good catch. Thanks @adoroszlai.
Updated new commit. I've added clientAddress to the #getFileStatus call. Also, I've moved #getFileStatus call outside BUCKET_LOCK so that it will get the benefit of doing 'sort' and 'refreshPipeline' outside BUCKET_LOCK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#issuecomment-694876885
Thanks a lot @adoroszlai for review help and merging it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r483649487
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1783,7 +1802,9 @@ private OzoneFileStatus getOzoneFileStatus(String volumeName,
// if the key is a file then do refresh pipeline info in OM by asking SCM
if (fileKeyInfo != null) {
- refreshPipeline(fileKeyInfo);
+ if (refreshPipeline) {
Review comment:
Yes, both points make sense. Thanks for noticing the duplicate call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] rakeshadr commented on a change in pull request #1385: HDDS-3947: Sort DNs for client when the key is a file for #getFileStatus #listStatus APIs
Posted by GitBox <gi...@apache.org>.
rakeshadr commented on a change in pull request #1385:
URL: https://github.com/apache/hadoop-ozone/pull/1385#discussion_r489309466
##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1783,7 +1802,9 @@ private OzoneFileStatus getOzoneFileStatus(String volumeName,
// if the key is a file then do refresh pipeline info in OM by asking SCM
if (fileKeyInfo != null) {
- refreshPipeline(fileKeyInfo);
+ if (refreshPipeline) {
Review comment:
OK, Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org