[GitHub] [incubator-pinot] kishoreg commented on a change in pull request #4243: Add support for passing headers in pinot client

[GitBox <gi...@apache.org>]

kishoreg commented on a change in pull request #4243: Add support for passing headers in pinot client
URL: https://github.com/apache/incubator-pinot/pull/4243#discussion_r288641904
 
 

 ##########
 File path: pinot-api/src/main/java/org/apache/pinot/client/PinotClientTransportFactory.java
 ##########
 @@ -18,9 +18,11 @@
  */
 package org.apache.pinot.client;
 
+import java.util.Map;
+
 /**
  * Factory for client transports.
  */
 interface PinotClientTransportFactory {
-  PinotClientTransport buildTransport();
+  PinotClientTransport buildTransport(Map<String, String> headers);
 
 Review comment:
   I had the same impression. But ConnectionFactory is the public interface and he has maintained backward compatibility by adding a new method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org