You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/02/21 13:49:39 UTC
Review Request 18353: Removed compile time dependency of mysql-connecotr-java
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek, Chip Childers, and David Nalley.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
Repository: cloudstack-git
Description
-------
When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
The licence is not supporting to include this binary in the final package.
We should remove the compile time dependency on this module.
Diffs
-----
framework/db/pom.xml 7347115
Diff: https://reviews.apache.org/r/18353/diff/
Testing
-------
Tested that mvn build is not broken because of this change.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 18353: Removed compile time dependency of
mysql-connecotr-java
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/#review35145
-----------------------------------------------------------
Hey,
I think the main problem here is that there are references in the source code to com.mysql. Those should be removed or made optional.
I've taken this change into commit ac00ab0087ca8f59184121697f7ac4343a694093
Cheers,
Hugo
- Hugo Trippaers
On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18353/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 1:15 p.m.)
>
>
> Review request for cloudstack, Chip Childers and David Nalley.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
> The licence is not supporting to include this binary in the final package.
> We should remove the compile time dependency on this module.
>
>
> Diffs
> -----
>
> framework/db/pom.xml 7347115
>
> Diff: https://reviews.apache.org/r/18353/diff/
>
>
> Testing
> -------
>
> Tested that mvn build is not broken because of this change.
> Also did a basic sanity run time test that DB functionality is not broken.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 18353: Removed compile time dependency of
mysql-connecotr-java
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
> On Feb. 21, 2014, 2:01 p.m., Hugo Trippaers wrote:
> > Note that this change does not actually make a difference unless all other poms that have mysql as a requirement are modified.
Yes I realized this after changes are done to my original changes related to DB HA. I realized that it is getting bundled even before my original changes.
- Damodar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/#review35146
-----------------------------------------------------------
On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18353/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 1:15 p.m.)
>
>
> Review request for cloudstack, Chip Childers and David Nalley.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
> The licence is not supporting to include this binary in the final package.
> We should remove the compile time dependency on this module.
>
>
> Diffs
> -----
>
> framework/db/pom.xml 7347115
>
> Diff: https://reviews.apache.org/r/18353/diff/
>
>
> Testing
> -------
>
> Tested that mvn build is not broken because of this change.
> Also did a basic sanity run time test that DB functionality is not broken.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 18353: Removed compile time dependency of
mysql-connecotr-java
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/#review35146
-----------------------------------------------------------
Note that this change does not actually make a difference unless all other poms that have mysql as a requirement are modified.
- Hugo Trippaers
On Feb. 21, 2014, 1:15 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18353/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 1:15 p.m.)
>
>
> Review request for cloudstack, Chip Childers and David Nalley.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
> The licence is not supporting to include this binary in the final package.
> We should remove the compile time dependency on this module.
>
>
> Diffs
> -----
>
> framework/db/pom.xml 7347115
>
> Diff: https://reviews.apache.org/r/18353/diff/
>
>
> Testing
> -------
>
> Tested that mvn build is not broken because of this change.
> Also did a basic sanity run time test that DB functionality is not broken.
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 18353: Removed compile time dependency of
mysql-connecotr-java
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 1:15 p.m.)
Review request for cloudstack, Chip Childers and David Nalley.
Changes
-------
updated Testing Done section
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
Repository: cloudstack-git
Description
-------
When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
The licence is not supporting to include this binary in the final package.
We should remove the compile time dependency on this module.
Diffs
-----
framework/db/pom.xml 7347115
Diff: https://reviews.apache.org/r/18353/diff/
Testing (updated)
-------
Tested that mvn build is not broken because of this change.
Also did a basic sanity run time test that DB functionality is not broken.
Thanks,
Damodar Reddy Talakanti
Re: Review Request 18353: Removed compile time dependency of
mysql-connecotr-java
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18353/
-----------------------------------------------------------
(Updated Feb. 21, 2014, 12:51 p.m.)
Review request for cloudstack, Chip Childers and David Nalley.
Changes
-------
removed Abhi from the list as he is not aware of the licensing issues.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-6152
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-6152
Repository: cloudstack-git
Description
-------
When we added DB-HA we made mysql-connector-java dependency as provided in "framework/db/pom.xml".
The licence is not supporting to include this binary in the final package.
We should remove the compile time dependency on this module.
Diffs
-----
framework/db/pom.xml 7347115
Diff: https://reviews.apache.org/r/18353/diff/
Testing
-------
Tested that mvn build is not broken because of this change.
Thanks,
Damodar Reddy Talakanti