You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/21 22:39:51 UTC
[GitHub] [airflow] jedcunningham opened a new pull request #20456: Update the "releasing Airflow" docs
jedcunningham opened a new pull request #20456:
URL: https://github.com/apache/airflow/pull/20456
I'm finding less and less each cycle 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#issuecomment-999144080
Been there, done that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#discussion_r773489272
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -352,7 +352,7 @@ is not supposed to be used by and advertised to the end-users who do not read th
(both airflow and latest provider packages).
```shell script
- git push origin ${VERSION}
+ git push origin tag ${VERSION}
Review comment:
The original should work too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham merged pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
jedcunningham merged pull request #20456:
URL: https://github.com/apache/airflow/pull/20456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#discussion_r773551513
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -352,7 +352,7 @@ is not supposed to be used by and advertised to the end-users who do not read th
(both airflow and latest provider packages).
```shell script
- git push origin ${VERSION}
+ git push origin tag ${VERSION}
Review comment:
TIL this is a thing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#discussion_r773692083
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -352,7 +352,7 @@ is not supposed to be used by and advertised to the end-users who do not read th
(both airflow and latest provider packages).
```shell script
- git push origin ${VERSION}
+ git push origin tag ${VERSION}
Review comment:
Git never ceases to amaze me. Every time I get to do something really complex in git, it really is just a matter of looking hard enough. There has ALWAYS been a one liner (even if a line is long) that does precisely what I wanted to do - no matter how complex the thing was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#issuecomment-999144627
BTW. At the moment you stop finding them, it's the time to start mentoring a Padawan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#issuecomment-999144127
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #20456: Update the "releasing Airflow" docs
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #20456:
URL: https://github.com/apache/airflow/pull/20456#discussion_r773490053
##########
File path: dev/README_RELEASE_AIRFLOW.md
##########
@@ -352,7 +352,7 @@ is not supposed to be used by and advertised to the end-users who do not read th
(both airflow and latest provider packages).
```shell script
- git push origin ${VERSION}
+ git push origin tag ${VERSION}
Review comment:
Indeed, but this is safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org